Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] bump reva to test the spaceid change #7975

Closed
wants to merge 1 commit into from
Closed

[full-ci] bump reva to test the spaceid change #7975

wants to merge 1 commit into from

Conversation

butonic
Copy link
Member

@butonic butonic commented Dec 14, 2023 •
edited
Loading

@update-docs Update Docs
Copy link

update-docs bot commented Dec 14, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from kobergj December 14, 2023 09:56
@butonic butonic self-assigned this Dec 14, 2023
@individual-it
Copy link
Member

cannot build it

go build -v -tags 'disable_crypt' -ldflags '-X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=warn -s -w -X "github.com/owncloud/ocis/v2/ocis-pkg/version.String=9c00f2c73d" -X "github.com/owncloud/ocis/v2/ocis-pkg/version.Tag=" -X "github.com/owncloud/ocis/v2/ocis-pkg/version.Date=20231214"' -o bin/ocis ./cmd/ocis
github.com/cs3org/reva/v2/pkg/ocm/storage/received
# github.com/cs3org/reva/v2/pkg/ocm/storage/received
../vendor/github.com/cs3org/reva/v2/pkg/ocm/storage/received/ocm.go:88:9: cannot use BearerAuthenticator{} (value of type BearerAuthenticator) as gowebdav.Authenticator value in return statement: BearerAuthenticator does not implement gowebdav.Authenticator (wrong type for method Authorize)
		have Authorize(*http.Client, *http.Request, string) error
		want Authorize(*http.Request, string, string)
../vendor/github.com/cs3org/reva/v2/pkg/ocm/storage/received/ocm.go:191:16: undefined: gowebdav.NewAuthClient
../vendor/github.com/cs3org/reva/v2/pkg/ocm/storage/received/ocm.go:191:49: undefined: gowebdav.NewPreemptiveAuth
../vendor/github.com/cs3org/reva/v2/pkg/ocm/storage/received/ocm.go:290:22: client.StatWithProps undefined (type *gowebdav.Client has no field or method StatWithProps)
../vendor/github.com/cs3org/reva/v2/pkg/ocm/storage/received/ocm.go:307:22: client.ReadDirWithProps undefined (type *gowebdav.Client has no field or method ReadDirWithProps)
make: *** [../.make/go.mk:102: bin/ocis] Fehler 1

@butonic
Copy link
Member Author

butonic commented Dec 14, 2023 •
edited
Loading

@aduffeck ocm got merged in reva ... is there a pr that bumps reva for that? ... nevermind, found #7973

@aduffeck
Copy link
Contributor

@butonic yes, that's: #7973 Still fighting CI however

@butonic butonic force-pushed the fix-ocdav-spaceid branch 2 times, most recently from 00dd58d to f668a72 Compare December 18, 2023 09:04
@butonic
Copy link
Member Author

butonic commented Dec 18, 2023

hm, this smells like a new flakyness:

  Scenario Outline: send last chunk twice                                                                                   # /drone/src/tests/acceptance/features/coreApiWebdavUploadTUS/lowLevelUpload.feature:53
    Given using <dav-path-version> DAV path                                                                                 # FeatureContext::usingOldOrNewDavPath()
    And user "Alice" has created a new TUS resource on the WebDAV API with these headers:                                   # TUSContext::userHasCreatedNewTUSResourceWithHeaders()
      | Upload-Length   | 10                    |
      | Upload-Metadata | filename ZmlsZS50eHQ= |
    When user "Alice" sends a chunk to the last created TUS Location with offset "0" and data "123" using the WebDAV API    # TUSContext::userSendsAChunkToTUSLocationWithOffsetAndData()
    And user "Alice" sends a chunk to the last created TUS Location with offset "3" and data "4567890" using the WebDAV API # TUSContext::userSendsAChunkToTUSLocationWithOffsetAndData()
    And user "Alice" sends a chunk to the last created TUS Location with offset "3" and data "0000000" using the WebDAV API # TUSContext::userSendsAChunkToTUSLocationWithOffsetAndData()
    Then the HTTP status code should be "404"                                                                               # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/file.txt" for user "Alice" should be "1234567890"                                             # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | dav-path-version |
      | old              |
      | new              |
        Failed step: Then the HTTP status code should be "404"
        HTTP status code 500 is not the expected value 404
        Failed asserting that 500 matches expected '404'.
      | spaces           |

individual-it
individual-it reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works for me as expected

@individual-it individual-it mentioned this pull request Dec 18, 2023
Merged
@butonic
bump reva
0c68af5 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

individual-it
individual-it approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, used in owncloud/ocis-php-sdk#130

@micbar
Copy link
Contributor

micbar commented Dec 19, 2023

please rebase

@butonic
Copy link
Member Author

butonic commented Dec 19, 2023

cs3org/reva#4407 was merged as part of #7989

@butonic butonic closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@butonic butonic

Labels
Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butonic @individual-it @aduffeck @micbar